Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of deprecated get_proj_coords_dask #711

Merged
merged 2 commits into from May 7, 2019

Conversation

sfinkens
Copy link
Member

@sfinkens sfinkens commented Apr 10, 2019

pyresample.AreaDefinition.get_proj_coords_dask is deprecated. Use get_proj_coords(chunks=...) instead.

  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff

@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #711 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
+ Coverage   79.99%   79.99%   +<.01%     
==========================================
  Files         147      147              
  Lines       21471    21472       +1     
==========================================
+ Hits        17176    17177       +1     
  Misses       4295     4295
Impacted Files Coverage Δ
satpy/readers/utils.py 71.42% <100%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff45d3f...fe5fc14. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0009%) to 79.997% when pulling fe5fc14 on sfinkens:get-proj-coords-dask-deprecated into ff45d3f on pytroll:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0009%) to 79.997% when pulling fe5fc14 on sfinkens:get-proj-coords-dask-deprecated into ff45d3f on pytroll:master.

@mraspaud mraspaud added component:readers enhancement code enhancements, features, improvements labels Apr 10, 2019
@mraspaud mraspaud added this to the v0.15 milestone Apr 10, 2019
@mraspaud mraspaud merged commit 79b4da3 into pytroll:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants