Fix 'mitiff' writer not clipping enhanced data before scaling to 8 bit values #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ced values to mitiff
TAlonglong
changed the title
Codecov Report
@@ Coverage Diff @@
## master #712 +/- ##
==========================================
+ Coverage 79.99% 80.02% +0.02%
==========================================
Files 147 147
Lines 21471 21498 +27
==========================================
+ Hits 17176 17203 +27
Misses 4295 4295
Continue to review full report at Codecov.
|
|
Will try to add a test for this. |
mraspaud
reviewed
Apr 11, 2019
| tif = TIFF.open(os.path.join(self.base_dir, filename)) | ||
| for image in tif.iter_images(): | ||
| np.testing.assert_allclose(image, expected, atol=1.e-6, rtol=0) | ||
|
|
There was a problem hiding this comment.
Could you delete the file when the test is finished ? Or do you do that later ?
There was a problem hiding this comment.
I think cleanup does that. Will check
There was a problem hiding this comment.
tearDown removes the temp directory.
djhoese
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After enhancement some data points may have values lower than 0.
Clip this to 0 before scaling to 8bit values.
This is needed in the mitiff writer as the 0 value is treated as nodata.