Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeowners #724

Merged
merged 1 commit into from Apr 24, 2019
Merged

Add codeowners #724

merged 1 commit into from Apr 24, 2019

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Apr 12, 2019

Add a codeowners file

@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #724 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #724   +/-   ##
=======================================
  Coverage   80.01%   80.01%           
=======================================
  Files         147      147           
  Lines       21498    21498           
=======================================
  Hits        17202    17202           
  Misses       4296     4296

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88c0f63...22a6c7c. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.017% when pulling 22a6c7c on mraspaud:feature-codeowners into 88c0f63 on pytroll:master.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have to list us for each individual file? Or is that just for clarity? No big deal either way.

@mraspaud
Copy link
Member Author

No, some files aren't listed and falls back to *. The others are more specific

@mraspaud
Copy link
Member Author

To be clear, the specific files takes precedence and overrule *

@mraspaud mraspaud self-assigned this Apr 24, 2019
@mraspaud mraspaud merged commit 97c3451 into pytroll:master Apr 24, 2019
@mraspaud mraspaud deleted the feature-codeowners branch April 24, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants