Fix viirs sdr reader to allow ivcdb files in the sdr directory #731
Conversation
Bring my fork up to date
Bring my fork up to date
…rectory Signed-off-by: Adam Dybbroe <Adam.Dybbroe@smhi.se>
There was a problem hiding this comment.
My initial reaction is that users should be providing files that can't be read by the reader. However, it is also the readers fault for matching files that is doesn't know how to read. However (again), the VIIRS SDR reader is a pretty special case.
@mraspaud can this be updated to not have a KeyError if it doesn't understand one of the file types? I'm ok adding what @adybbroe has so far, but can we make it so things don't completely die?
|
Yes, I was wondering about it also, but I don't think we have a way of gracefully failing the filehandler init... |
|
Ah ok, sounds good. |
Codecov Report
@@ Coverage Diff @@
## master #731 +/- ##
=======================================
Coverage 80.02% 80.02%
=======================================
Files 147 147
Lines 21498 21498
=======================================
Hits 17203 17203
Misses 4295 4295
Continue to review full report at Codecov.
|
CSPP (and IPOPP) may output Dual Gain calibration files with the prefix IVCDB. As of now, when having these files in the directory together with the other SDR files, satpy fails with a
KeyErrorCSPP version 3.2 will output these files on default.
git diff origin/master -- "*py" | flake8 --diff