Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VIIRS EDR Active Fires #733

Merged
merged 19 commits into from May 9, 2019
Merged

Conversation

rdaruwala
Copy link
Contributor

@rdaruwala rdaruwala commented Apr 26, 2019

Updates the VIIRS EDR Active Fires reader to read AFEDR, AFIMG, and AFMOD NetCDF and CSV files.

For AFEDR and AFMOD, the following parameters can be accessed:

  • confidence_pct
  • power
  • T13
  • latitude & longitude

For AFIMG, the following parameters can be accessed:

@rdaruwala rdaruwala changed the title Reader fires Fix VIIRS EDR Active Fires Apr 26, 2019
@rdaruwala rdaruwala changed the title Fix VIIRS EDR Active Fires Update VIIRS EDR Active Fires Apr 26, 2019
@coveralls
Copy link

coveralls commented Apr 26, 2019

Coverage Status

Coverage increased (+0.1%) to 80.77% when pulling 9c72cbd on rdaruwala:reader-fires into 5fee138 on pytroll:master.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions and a couple changes.

Also, could you add some information in the top docstring of the reader python module about the different file types (AFEDR is the pre-release (dev) version of the product); like MOD versus IMG differences (confidence, etc)?

satpy/readers/viirs_edr_active_fires.py Outdated Show resolved Hide resolved
satpy/etc/readers/viirs_edr_active_fires.yaml Outdated Show resolved Hide resolved
satpy/etc/readers/viirs_edr_active_fires.yaml Outdated Show resolved Hide resolved
satpy/etc/readers/viirs_edr_active_fires.yaml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #733 into master will increase coverage by 0.11%.
The diff coverage is 98.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #733      +/-   ##
==========================================
+ Coverage   80.67%   80.78%   +0.11%     
==========================================
  Files         149      149              
  Lines       21661    21773     +112     
==========================================
+ Hits        17474    17590     +116     
+ Misses       4187     4183       -4
Impacted Files Coverage Δ
satpy/readers/viirs_edr_active_fires.py 93.61% <100%> (+3.61%) ⬆️
.../tests/reader_tests/test_viirs_edr_active_fires.py 97.16% <98.47%> (+0.98%) ⬆️
satpy/writers/geotiff.py 41.66% <0%> (-0.36%) ⬇️
satpy/readers/yaml_reader.py 93.36% <0%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fee138...9c72cbd. Read the comment docs.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like some cleanup on the platform handling. Otherwise looking good.

satpy/readers/viirs_edr_active_fires.py Outdated Show resolved Hide resolved
@mraspaud mraspaud added the enhancement code enhancements, features, improvements label May 6, 2019
@djhoese
Copy link
Member

djhoese commented May 9, 2019

I was going to ask why the CLASS active fires files weren't included but then remembered that the files I gave you didn't have any fires in them. I went to CLASS to try to find some and can't even find the product to be able to download new files...so I guess we'll support them when they are more widely used/available.

@djhoese djhoese merged commit 81b3334 into pytroll:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update 'viirs_edr_active_fires' reader to read newest algorithm output
5 participants