Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FY-3D MERSI-2 L1B Reader (mersi2_l1b) #740

Merged
merged 10 commits into from May 7, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Apr 28, 2019

This PR adds a reader for the MERSI-2 L1B data format which are HDF5 files. This PR also includes some clean up of the VIRR reader (removing the "level" from the DatasetID).

TODO

@djhoese djhoese added enhancement code enhancements, features, improvements component:readers work in progress labels Apr 28, 2019
@djhoese djhoese self-assigned this Apr 28, 2019
satpy/readers/mersi2_l1b.py Show resolved Hide resolved
satpy/readers/mersi2_l1b.py Outdated Show resolved Hide resolved
satpy/readers/mersi2_l1b.py Show resolved Hide resolved
satpy/readers/mersi2_l1b.py Outdated Show resolved Hide resolved
@djhoese djhoese mentioned this pull request Apr 30, 2019
5 tasks
@djhoese djhoese changed the title [WIP] Add FY-3D MERSI-2 L1B Reader (mersi2_l1b) Add FY-3D MERSI-2 L1B Reader (mersi2_l1b) May 7, 2019
@djhoese djhoese marked this pull request as ready for review May 7, 2019 17:13
@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #740 into master will increase coverage by 0.27%.
The diff coverage is 97.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #740      +/-   ##
==========================================
+ Coverage   81.14%   81.41%   +0.27%     
==========================================
  Files         152      154       +2     
  Lines       22068    22427     +359     
==========================================
+ Hits        17908    18260     +352     
- Misses       4160     4167       +7
Impacted Files Coverage Δ
satpy/scene.py 90.08% <ø> (ø) ⬆️
satpy/readers/hdf5_utils.py 92.3% <0%> (ø) ⬆️
satpy/tests/reader_tests/__init__.py 97.87% <100%> (+0.04%) ⬆️
satpy/tests/reader_tests/test_virr_l1b.py 97.16% <100%> (-0.03%) ⬇️
satpy/readers/virr_l1b.py 98.3% <87.5%> (+0.02%) ⬆️
satpy/readers/mersi2_l1b.py 96.29% <96.29%> (ø)
satpy/tests/reader_tests/test_mersi2_l1b.py 98.55% <98.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f05e0a...1f67a3e. Read the comment docs.

@coveralls
Copy link

coveralls commented May 7, 2019

Coverage Status

Coverage increased (+0.3%) to 81.42% when pulling 1f67a3e on djhoese:feature-mersi2-reader into 1f05e0a on pytroll:master.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djhoese
Copy link
Member Author

djhoese commented May 7, 2019

As discussed on slack, I've updated the reader so it preserves the uint16 data type when the calibration is "counts".

@djhoese djhoese merged commit 8fd35b3 into pytroll:master May 7, 2019
@djhoese djhoese deleted the feature-mersi2-reader branch May 7, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add reader for FY3D MERSI2 L1B data
4 participants