Add scanline timestamps to seviri_l1b_hrit #752
Conversation
Make them available as non-dimensional coordinate
sfinkens
requested review from
adybbroe,
djhoese,
mraspaud and
sjoro
as code owners
Codecov Report
@@ Coverage Diff @@
## master #752 +/- ##
==========================================
+ Coverage 80.68% 80.75% +0.06%
==========================================
Files 149 149
Lines 21650 21871 +221
==========================================
+ Hits 17469 17662 +193
- Misses 4181 4209 +28
Continue to review full report at Codecov.
|
sfinkens
added
component:enhancements
component:readers
enhancement
| return datetime(1958, 1, 1) + timedelta(days=float(days), | ||
| milliseconds=float(msecs)) | ||
| if isinstance(days, (int, float)): | ||
| days = np.array([days], dtype='int64') |
There was a problem hiding this comment.
What if days is a float ? Shouldn't something go over to msecs ?
There was a problem hiding this comment.
Right, that doesn't make sense. Both days and msecs are expected to be integer, so the check for float should be removed. It was meant to check whether the input is scalar. But maybe np.isscalar is a better option
| days.astype('timedelta64[D]') + msecs.astype('timedelta64[ms]') | ||
|
|
||
| if len(time) == 1: | ||
| return time[0] |
There was a problem hiding this comment.
Is this needed ? Don't we always have the time as an array with multiple values .?
There was a problem hiding this comment.
Yes. the scanline timestamps are always multiple values. The use case I had in mind are attributes which contain a single timestamp (day, msec) (not sure whether they exist). If scalars are provided to the function, it would return a scalar, not an array. But I agree that it might be confusing to have different return types.
|
Oh, I completely forgot about the big picture 😅 In the native format each record has its own timestamp, but it should be relatively easy to provide it. Never used the netCDF format before. I will order one at EUM and see whether it includes scanline timestamps. |
- Use np.isscalar to check for scalar input - Replace 1958-01-01 00:00 with NaT in this method already
|
@sjoro Summarizing the discussion on slack:
|
|
The conclusion was we leave the scanline timestamps for the other SEVIRI readers to another PR |
Named it
acq_timebecause it is a non-dimension coordinate, in contrast totimewhich is expected to be a dimension coordinate in the CF Writer (see also http://xarray.pydata.org/en/stable/data-structures.html?highlight=coordinates#coordinates).Resampling drops the acquisition time which I think is correct
I changed the return value of
satpy.readers.seviri_base.get_cds_timeto datetime64, but it hasn't been used anywhere yetAdded a basic reader introduction and a recipe to enable
.sel(time=...)viaMultiIndexto the docsTests added
Tests passed
Passes
git diff origin/master -- "*py" | flake8 --diffFully documented