Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mersi2_l1b reader setting sensor as a set object #761

Merged
merged 1 commit into from May 10, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented May 10, 2019

The DataArray 'sensor' attribute should be a single string right now. Rayleigh correction was complaining about not being able to serialize the 'sensor' attribute.

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff
  • Fully documented

@djhoese djhoese added the bug label May 10, 2019
@djhoese djhoese requested a review from mraspaud as a code owner May 10, 2019 19:06
@djhoese djhoese self-assigned this May 10, 2019
@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #761 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #761   +/-   ##
=======================================
  Coverage   81.61%   81.61%           
=======================================
  Files         157      157           
  Lines       22636    22636           
=======================================
  Hits        18475    18475           
  Misses       4161     4161
Impacted Files Coverage Δ
satpy/readers/mersi2_l1b.py 96.38% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bfbac6...c3c717f. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.618% when pulling c3c717f on djhoese:bugfix-mersi2-sensor-name into 1bfbac6 on pytroll:master.

@djhoese djhoese merged commit 6c439fb into pytroll:master May 10, 2019
@djhoese djhoese deleted the bugfix-mersi2-sensor-name branch May 10, 2019 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants