Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NullHandler not allowing warning/error logs to be printed to console #778

Merged
merged 1 commit into from May 21, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented May 17, 2019

See #777 for details. This now results in python 3 printing the raw string of any warning or error messages from the logger and prints nothing with python 2 as the NullHandler is still added.

@djhoese djhoese added the bug label May 17, 2019
@djhoese djhoese requested a review from mraspaud as a code owner May 17, 2019 19:26
@djhoese djhoese self-assigned this May 17, 2019
@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #778 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
+ Coverage   81.84%   81.84%   +<.01%     
==========================================
  Files         158      158              
  Lines       22735    22777      +42     
==========================================
+ Hits        18607    18642      +35     
- Misses       4128     4135       +7
Impacted Files Coverage Δ
satpy/utils.py 62.96% <100%> (-0.47%) ⬇️
satpy/readers/avhrr_l1b_gaclac.py 90% <0%> (-1.43%) ⬇️
satpy/readers/__init__.py 93.67% <0%> (-1.21%) ⬇️
satpy/scene.py 90.59% <0%> (+0.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 042426c...f9f583c. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 81.813% when pulling f9f583c on djhoese:bugfix-null-logger into 042426c on pytroll:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 81.813% when pulling f9f583c on djhoese:bugfix-null-logger into 042426c on pytroll:master.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Pytroll Contributor's Week - Spring 2019 - Madison, WI automation moved this from In progress to Reviewer approved May 21, 2019
@mraspaud mraspaud merged commit a0f9371 into pytroll:master May 21, 2019
Pytroll Contributor's Week - Spring 2019 - Madison, WI automation moved this from Reviewer approved to Done May 21, 2019
@djhoese djhoese deleted the bugfix-null-logger branch May 17, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Log warning and error messages are not printed to console
3 participants