-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug mitiff writer when only one channel is to be written with calibration information #792
Bug mitiff writer when only one channel is to be written with calibration information #792
Conversation
Codecov Report
@@ Coverage Diff @@
## master #792 +/- ##
==========================================
+ Coverage 82.27% 82.93% +0.65%
==========================================
Files 159 163 +4
Lines 22996 23579 +583
==========================================
+ Hits 18921 19555 +634
+ Misses 4075 4024 -51
Continue to review full report at Codecov.
|
@TAlonglong is this ready to be merged ? |
It should be, but I looked quick at the test coverage and it looks a bit strange. So I need to check things over again. Maybe today, if not I will take a few days of, then next week. |
No problem, take your time. Just ping me when you want this merged. |
Think I'm done now. Can you have a look @mraspaud when you can spare some time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There is a bug in the mitiff writer when saving only one channel with calibration information. The writer assumed datasets to be a list at one point and used the 'bands' dimension when it was not there.
flake8 satpy