Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug mitiff writer when only one channel is to be written with calibration information #792

Merged

Conversation

TAlonglong
Copy link
Collaborator

@TAlonglong TAlonglong commented May 28, 2019

There is a bug in the mitiff writer when saving only one channel with calibration information. The writer assumed datasets to be a list at one point and used the 'bands' dimension when it was not there.

  • Tests added and test suite added to parent suite
  • Tests passed
  • Passes flake8 satpy

@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #792 into master will increase coverage by 0.65%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #792      +/-   ##
==========================================
+ Coverage   82.27%   82.93%   +0.65%     
==========================================
  Files         159      163       +4     
  Lines       22996    23579     +583     
==========================================
+ Hits        18921    19555     +634     
+ Misses       4075     4024      -51
Impacted Files Coverage Δ
satpy/tests/writer_tests/test_mitiff.py 97.96% <100%> (+1.38%) ⬆️
satpy/writers/mitiff.py 91.68% <100%> (+11.8%) ⬆️
satpy/readers/seviri_l1b_nc.py 15.53% <0%> (-2.29%) ⬇️
satpy/writers/utils.py 100% <0%> (ø)
satpy/tests/reader_tests/test_vaisala_gld360.py 96% <0%> (ø)
satpy/tests/writer_tests/test_utils.py 93.33% <0%> (ø)
satpy/readers/vaisala_gld360.py 90% <0%> (ø)
satpy/tests/reader_tests/__init__.py 98% <0%> (+0.04%) ⬆️
satpy/scene.py 90.08% <0%> (+0.17%) ⬆️
satpy/tests/writer_tests/test_cf.py 98.91% <0%> (+0.23%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd65262...347ed6c. Read the comment docs.

@coveralls
Copy link

coveralls commented May 28, 2019

Coverage Status

Coverage increased (+0.7%) to 82.93% when pulling 347ed6c on TAlonglong:bug-mitiff-writer-only-one-channel into cd65262 on pytroll:master.

@mraspaud
Copy link
Member

@TAlonglong is this ready to be merged ?

@TAlonglong
Copy link
Collaborator Author

It should be, but I looked quick at the test coverage and it looks a bit strange. So I need to check things over again. Maybe today, if not I will take a few days of, then next week.

@mraspaud
Copy link
Member

No problem, take your time. Just ping me when you want this merged.

@TAlonglong
Copy link
Collaborator Author

Think I'm done now. Can you have a look @mraspaud when you can spare some time?

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud added this to the v0.16 milestone Jun 5, 2019
@mraspaud mraspaud merged commit 31d9623 into pytroll:master Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants