Feature ewa resampling #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| **kwargs): | ||
| rows = self.cache["rows"] | ||
| cols = self.cache["cols"] | ||
| out_arr = np.empty(data.shape, dtype=data.dtype) |
There was a problem hiding this comment.
Actually I think this is a bug. I think it should be rows.shape instead of data.shape which is why I did empty in the first place.
The 'resample' method imported at the top of projectable.py was moved to inside the resample method to avoid circular imports. The resample tests were still patching the global import. Now they modify the original function. I also imported unittest2 in a few modules to be more consistent.
The resample module import now happens inside the test so only the resample tests fail instead of halting all unittests.
|
What's the status here ? |
|
This is currently waiting for a stable pyresample version with EWA resampling so satpy with EWA resampling can be properly tested. |
mraspaud
pushed a commit
that referenced
this pull request
Jun 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new resampling method known as Elliptical Weighted Averaging or EWA. This is the default resampling method used by P2G. These commits require the pyresample PR for the actual "work" code for EWA: pytroll/pyresample#37
I still need to write tests and clean some things up.