Fix 'virr_l1b' reader when slope attribute is 0 #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update project
…l-master # Conflicts: # satpy/readers/virr_l1b.py
Codecov Report
@@ Coverage Diff @@
## master #800 +/- ##
==========================================
+ Coverage 82.26% 82.27% +<.01%
==========================================
Files 159 159
Lines 22998 23003 +5
==========================================
+ Hits 18920 18925 +5
Misses 4078 4078
Continue to review full report at Codecov.
|
djhoese
requested changes
Jun 2, 2019
There was a problem hiding this comment.
I'm guessing by reading this that Slope in the file can either be an array or a single value? Or is the single value (scalar) only coming from your tests?
What happened to what we talked about in person with slope = slope.where(slope != 0, 1)? Would it be cleaner to make a small helper function for this check so it doesn't have to be repeated so many times? Or maybe that's overkill.
stickler-ci
reviewed
Jun 3, 2019
djhoese
changed the title
djhoese
changed the title
djhoese
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If slope in the file being read is 0, convert slope to 1 (This came about from Longitude in FY3B files).
flake8 satpyAUTHORS.mdif not there already