Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag_meanings and flag_values to 'viirs_edr_active_fires' categories #806

Merged
merged 2 commits into from Jun 17, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jun 6, 2019

I noticed that the "confidence_cat" dataset for VIIRS EDR Active Fires didn't have flag meanings and values defined. This PR adds them and makes the DataArray more CF compliant and hopefully easier to use.

  • Tests added and test suite added to parent suite
  • Tests passed
  • Passes flake8 satpy

@djhoese djhoese added component:readers enhancement code enhancements, features, improvements labels Jun 6, 2019
@djhoese djhoese self-assigned this Jun 6, 2019
@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #806 into master will increase coverage by <.01%.
The diff coverage is 92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #806      +/-   ##
==========================================
+ Coverage   82.95%   82.95%   +<.01%     
==========================================
  Files         163      163              
  Lines       23610    23622      +12     
==========================================
+ Hits        19586    19596      +10     
- Misses       4024     4026       +2
Impacted Files Coverage Δ
.../tests/reader_tests/test_viirs_edr_active_fires.py 97.21% <100%> (+0.04%) ⬆️
satpy/readers/viirs_edr_active_fires.py 90.74% <89.47%> (-2.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20e2063...0b8a6d8. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 6, 2019

Coverage Status

Coverage increased (+0.0002%) to 82.957% when pulling 0b8a6d8 on djhoese:feature-viirs-active-fires-flags into 20e2063 on pytroll:master.

Other readers use degrees_east instead of degree_east
@djhoese djhoese merged commit abe5b8b into pytroll:master Jun 17, 2019
@djhoese djhoese added this to the v0.16 milestone Jun 17, 2019
@djhoese djhoese deleted the feature-viirs-active-fires-flags branch June 17, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants