-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some documentation to modis readers similar to hrit #813
Conversation
satpy/readers/modis_l1b.py
Outdated
""" | ||
|
||
#following link is broken |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E265 block comment should start with '# '
satpy/readers/modis_l1b.py
Outdated
""" | ||
|
||
#following link is broken | ||
#- http://www.sciencedirect.com/science?_ob=MiamiImageURL&_imagekey=B6V6V-4700BJP-\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E265 block comment should start with '# '
satpy/readers/modis_l1b.py
Outdated
""" | ||
|
||
#following link is broken | ||
#- http://www.sciencedirect.com/science?_ob=MiamiImageURL&_imagekey=B6V6V-4700BJP-\ | ||
#3-27&_cdi=5824&_user=671124&_check=y&_orig=search&_coverDate=11%2F30%2F2002&vie\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E265 block comment should start with '# '
satpy/readers/modis_l1b.py
Outdated
#following link is broken | ||
#- http://www.sciencedirect.com/science?_ob=MiamiImageURL&_imagekey=B6V6V-4700BJP-\ | ||
#3-27&_cdi=5824&_user=671124&_check=y&_orig=search&_coverDate=11%2F30%2F2002&vie\ | ||
#w=c&wchp=dGLzVlz-zSkWz&md5=bac5bc7a4f08007722ae793954f1dd63&ie=/sdarticle.pdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E265 block comment should start with '# '
Anyone has a clue about what the broken link was about? |
@mraspaud what broken link? |
#following link is broken
#- http://www.sciencedirect.com/science?_ob=MiamiImageURL&_imagekey=B6V6V-4700BJP-\
#3-27&_cdi=5824&_user=671124&_check=y&_orig=search&_coverDate=11%2F30%2F2002&vie\
#w=c&wchp=dGLzVlz-zSkWz&md5=bac5bc7a4f08007722ae793954f1dd63&ie=/sdarticle.pdf |
satpy/readers/modis_l2.py
Outdated
@@ -15,11 +15,34 @@ | |||
# | |||
# You should have received a copy of the GNU General Public License along with | |||
# satpy. If not, see <http://www.gnu.org/licenses/>. | |||
"""Reader for MODIS L2 products written with HDF4 files. | |||
""""""Modis level 2 hdf-eos format reader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E999 SyntaxError: invalid syntax
@BENR0 Any information on that broken link? |
No I don't know what it's about. I didn't put it in there. Just noticed that it was broken when I tried it out while updating the documentation. So the question is who put it in there and can he/she remember what it was about? |
When it's not possible to find out what it was about I agree. |
Codecov Report
@@ Coverage Diff @@
## master #813 +/- ##
==========================================
+ Coverage 83.38% 83.83% +0.45%
==========================================
Files 165 167 +2
Lines 23983 24441 +458
==========================================
+ Hits 19998 20491 +493
+ Misses 3985 3950 -35
Continue to review full report at Codecov.
|
a pattern similar to the following one: | ||
|
||
.. parsed-literal:: | ||
M[O/Y]D02[1/H/Q]KM.A[date].[time].[collection].[processing_time].hdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this render properly? Or does it need an extra line between the parsed-literal and the pattern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http://rst.ninjs.org/ doesn't like the parsed-literal instruction...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mraspaud That may be a sphinx-only directive. Or it may need the extra line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://livesphinx.herokuapp.com/ Seems to be ok with no extra line and with an extra line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds documentation similar to the one already found for xrit readers.