New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix delayed generation of composites and composite resolution #828
Conversation
Codecov Report
@@ Coverage Diff @@
## master #828 +/- ##
==========================================
+ Coverage 83.9% 83.95% +0.04%
==========================================
Files 167 167
Lines 24445 24512 +67
==========================================
+ Hits 20511 20578 +67
Misses 3934 3934
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would it be possible to add some tests for this?
Good question :) |
Test added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How hard would it be to add a test for the delayed generation "empty" node stuff? I suppose that would be with the tests I usually write for reading. We must have one for delayed generation already.
I think this is ready for re-review. I'd like to have it included in the patch release if possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple things that could be cleaned up, but otherwise it looks good to me. I had one question about one of the tests.
Nice job deciphering my Scene/reader tests and adding your own.
Travis notification is stuck, but all tests pass. Merging now. |
This PR fixes three bugs in the composite generation part of satpy.
empty_node
is now a class attribute to make sure it is the same across multiple instances of the dependency tree. This fixes a bug appearing when the composite generation is delayed, which causes the dependency tree to be copied and previously a netempty_node
to be created.flake8 satpy