Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit configuration #832

Merged
merged 5 commits into from Jun 27, 2019
Merged

Add pre-commit configuration #832

merged 5 commits into from Jun 27, 2019

Conversation

mraspaud
Copy link
Member

Add pre-commit configuration

@mraspaud mraspaud requested a review from djhoese as a code owner June 27, 2019 07:08
@mraspaud mraspaud self-assigned this Jun 27, 2019
@mraspaud mraspaud added the enhancement code enhancements, features, improvements label Jun 27, 2019
@codecov
Copy link

codecov bot commented Jun 27, 2019 •
edited

Codecov Report

Merging #832 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #832      +/-   ##
=========================================
- Coverage    83.9%   83.9%   -0.01%     
=========================================
  Files         167     167              
  Lines       24445   24445              
=========================================
- Hits        20511   20510       -1     
- Misses       3934    3935       +1
Impacted Files Coverage Δ
satpy/readers/avhrr_l1b_gaclac.py 90.14% <0%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2654cf3...221b308. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 27, 2019 •
edited

Coverage Status

Coverage decreased (-0.004%) to 83.882% when pulling 221b308 on mraspaud:feature-precommit into 2654cf3 on pytroll:master.

djhoese
djhoese requested changes Jun 27, 2019
View reviewed changes
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the CONTRIBUTING documentation be updated to mention how to install the pre-commit stuff for this and what it does?

@mraspaud
Copy link
Member Author

Sure

@mraspaud Octobox
Copy link
Member Author

Done

djhoese
djhoese reviewed Jun 27, 2019
View reviewed changes
CONTRIBUTING.rst Outdated Show resolved Hide resolved
djhoese
djhoese reviewed Jun 27, 2019
View reviewed changes
CONTRIBUTING.rst Outdated Show resolved Hide resolved
mraspaud
mraspaud commented Jun 27, 2019
View reviewed changes
CONTRIBUTING.rst Outdated Show resolved Hide resolved
@mraspaud
Copy link
Member Author

Travis notification stuck again, merging

@mraspaud mraspaud merged commit d801e98 into pytroll:master Jun 27, 2019
@mraspaud mraspaud deleted the feature-precommit branch June 27, 2019 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhoese djhoese djhoese approved these changes

Assignees

@mraspaud mraspaud

Labels
enhancement code enhancements, features, improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mraspaud @coveralls @djhoese