Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cviirs reader to be more dask-friendly #842

Merged
merged 2 commits into from Jul 3, 2019
Merged

Fix cviirs reader to be more dask-friendly #842

merged 2 commits into from Jul 3, 2019

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Jul 2, 2019

Fix cviirs reader to be more dask-friendly

  • Tests added and test suite added to parent suite
  • Tests passed
  • Passes flake8 satpy
  • Fully documented

@mraspaud mraspaud added enhancement code enhancements, features, improvements component:readers labels Jul 2, 2019
@mraspaud mraspaud self-assigned this Jul 2, 2019
djhoese
djhoese approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing the read_dnb methods weren't being used? Otherwise, LGTM.

@mraspaud
Copy link
Member Author

mraspaud commented Jul 2, 2019

No, the functions I removed weren't used

@djhoese djhoese marked this pull request as ready for review July 2, 2019 15:49
@coveralls
Copy link

coveralls commented Jul 2, 2019 •
edited

Coverage Status

Coverage increased (+0.1%) to 84.095% when pulling bd9f482 on mraspaud:fix-cviirs into 7d6abe9 on pytroll:master.

@codecov
Copy link

codecov bot commented Jul 3, 2019 •
edited

Codecov Report

Merging #842 into master will increase coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #842     +/-   ##
=========================================
+ Coverage   83.98%   84.09%   +0.1%     
=========================================
  Files         167      167             
  Lines       24580    24546     -34     
=========================================
- Hits        20644    20642      -2     
+ Misses       3936     3904     -32
Impacted Files Coverage Δ
satpy/readers/viirs_compact.py 15.16% <0%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d6abe9...bd9f482. Read the comment docs.

@djhoese djhoese merged commit 7360647 into pytroll:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhoese djhoese djhoese approved these changes

Assignees

@mraspaud mraspaud

Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mraspaud @coveralls @djhoese