Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FY-4 naming to follow WMO Oscar naming #871

Merged
merged 2 commits into from Sep 19, 2019

Conversation

adybbroe
Copy link
Contributor

@adybbroe adybbroe commented Aug 9, 2019

Signed-off-by: Adam Dybbroe Adam.Dybbroe@smhi.se

Fixes the platform_name in the FY-4 AGRI reader, so the naming follows the WMO/Oscar standard.

  • Tests passed
  • Passes flake8 satpy

Signed-off-by: Adam Dybbroe <Adam.Dybbroe@smhi.se>
@djhoese
Copy link
Member

djhoese commented Aug 30, 2019

@adybbroe If you have time, could you merge this with master so the tests rerun?

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud added this to the v0.17.0 milestone Sep 12, 2019
@mraspaud
Copy link
Member

@adybbroe can you try merging with master ?

@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@34e4045). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #871   +/-   ##
=========================================
  Coverage          ?   85.15%           
=========================================
  Files             ?      174           
  Lines             ?    25502           
  Branches          ?        0           
=========================================
  Hits              ?    21717           
  Misses            ?     3785           
  Partials          ?        0
Impacted Files Coverage Δ
satpy/readers/agri_l1.py 99.04% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34e4045...67a6b3a. Read the comment docs.

@mraspaud mraspaud merged commit 78763f4 into pytroll:master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants