Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader for NWCSAF/MSG 2013 format #886

Merged
merged 18 commits into from Nov 6, 2019

Conversation

adybbroe
Copy link
Contributor

@adybbroe adybbroe commented Aug 27, 2019

Adding support to read the NWCSAF/MSG v2013 formattet cloud products.

Signed-off-by: Adam Dybbroe <Adam.Dybbroe@smhi.se>
Signed-off-by: Adam Dybbroe <Adam.Dybbroe@smhi.se>
Signed-off-by: Adam Dybbroe <Adam.Dybbroe@smhi.se>
@coveralls
Copy link

coveralls commented Aug 27, 2019

Coverage Status

Coverage increased (+0.07%) to 86.739% when pulling 462af23 on adybbroe:feature-old-nwcsaf-geo-format into e958d7d on pytroll:master.

Signed-off-by: Adam Dybbroe <Adam.Dybbroe@smhi.se>
Signed-off-by: Adam Dybbroe <Adam.Dybbroe@smhi.se>
@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #886 into master will increase coverage by 0.07%.
The diff coverage is 95.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #886      +/-   ##
==========================================
+ Coverage   86.66%   86.73%   +0.07%     
==========================================
  Files         177      179       +2     
  Lines       27036    27252     +216     
==========================================
+ Hits        23431    23638     +207     
- Misses       3605     3614       +9
Impacted Files Coverage Δ
satpy/composites/__init__.py 78.3% <0%> (-0.1%) ⬇️
satpy/tests/reader_tests/test_hdf5_utils.py 94.02% <100%> (+1.38%) ⬆️
satpy/tests/reader_tests/__init__.py 98.3% <100%> (+0.02%) ⬆️
satpy/readers/hdf5_utils.py 91.93% <90%> (-0.38%) ⬇️
satpy/tests/reader_tests/test_nwcsaf_msg.py 95.31% <95.31%> (ø)
satpy/readers/nwcsaf_msg2013_hdf5.py 96.1% <96.1%> (ø)
satpy/scene.py 90.53% <0%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e958d7d...462af23. Read the comment docs.

Signed-off-by: Adam Dybbroe <Adam.Dybbroe@smhi.se>
Signed-off-by: Adam Dybbroe <Adam.Dybbroe@smhi.se>
@adybbroe adybbroe marked this pull request as ready for review October 31, 2019 09:32
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this legacy (but important!) format reader. You're missing tests for the hdf5 utils changes, and for you reader.

@mraspaud
Copy link
Member

mraspaud commented Nov 4, 2019

Does this fix #888 ?

…erage

Signed-off-by: Adam Dybbroe <Adam.Dybbroe@smhi.se>
@adybbroe
Copy link
Contributor Author

adybbroe commented Nov 5, 2019

@mraspaud I suppose it does fix the old issue, as far as it needs fixing at least...

@mraspaud mraspaud changed the title Feature old nwcsaf geo format Reader for NWCSAF/MSG 2013 format Nov 6, 2019
@mraspaud mraspaud merged commit 64f99b2 into pytroll:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unintended/wrong behaviour of getitem method in HDF5FileHandler?
3 participants