Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MERSI-2 and VIRR readers being recognized by pyspectral #890

Merged
merged 4 commits into from
Aug 30, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Aug 29, 2019

This PR covers just about every category. It is a fix and an enhancement. This includes the changes from #884. Basically, I needed MERSI-2 and VIRR readers to work with rayleigh correct.

  • Tests added and test suite added to parent suite
  • Tests passed
  • Passes flake8 satpy
  • Fully documented

@djhoese djhoese added bug enhancement code enhancements, features, improvements component:readers component:compositors backwards-incompatibility Causes backwards incompatibility or introduces a deprecation labels Aug 29, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 84.644% when pulling bb07fb3 on djhoese:bugfix-virr-mersi2 into f9d0022 on pytroll:master.

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #890 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #890      +/-   ##
==========================================
+ Coverage   84.64%   84.64%   +<.01%     
==========================================
  Files         171      171              
  Lines       25035    25033       -2     
==========================================
- Hits        21191    21190       -1     
+ Misses       3844     3843       -1
Impacted Files Coverage Δ
satpy/readers/mersi2_l1b.py 96.38% <ø> (-0.09%) ⬇️
satpy/tests/reader_tests/test_virr_l1b.py 97.19% <100%> (ø) ⬆️
satpy/readers/virr_l1b.py 98.41% <100%> (ø) ⬆️
satpy/readers/avhrr_l1b_gaclac.py 91.54% <0%> (+1.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9d0022...bb07fb3. Read the comment docs.

@djhoese djhoese merged commit e061a4f into pytroll:master Aug 30, 2019
@djhoese djhoese deleted the bugfix-virr-mersi2 branch August 30, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompatibility Causes backwards incompatibility or introduces a deprecation bug component:compositors component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants