Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coefficients for FY-3B VIRR reflectance calibration #892

Merged
merged 2 commits into from Aug 30, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Aug 30, 2019

In my continued effort to figure out why VIRR true colors look so terrible...

@kathys pointed me to some new coefficients for getting the reflectances out of the VIRR files. The images look much better.

  • Tests added and test suite added to parent suite
  • Tests passed
  • Passes flake8 satpy

@djhoese djhoese added enhancement code enhancements, features, improvements component:readers labels Aug 30, 2019
@djhoese djhoese requested a review from mraspaud as a code owner August 30, 2019 19:46
@djhoese djhoese self-assigned this Aug 30, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 84.648% when pulling 445dcff on djhoese:feature-virr-coeffs into ebede6d on pytroll:master.

@codecov
Copy link

codecov bot commented Aug 30, 2019

Codecov Report

Merging #892 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #892      +/-   ##
==========================================
+ Coverage   84.64%   84.64%   +<.01%     
==========================================
  Files         171      171              
  Lines       25034    25046      +12     
==========================================
+ Hits        21190    21201      +11     
- Misses       3844     3845       +1
Impacted Files Coverage Δ
satpy/tests/reader_tests/test_virr_l1b.py 97.39% <100%> (+0.19%) ⬆️
satpy/readers/virr_l1b.py 98.5% <100%> (+0.09%) ⬆️
satpy/scene.py 90.47% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebede6d...445dcff. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 30, 2019

Codecov Report

Merging #892 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #892      +/-   ##
==========================================
+ Coverage   84.64%   84.64%   +<.01%     
==========================================
  Files         171      171              
  Lines       25034    25046      +12     
==========================================
+ Hits        21190    21201      +11     
- Misses       3844     3845       +1
Impacted Files Coverage Δ
satpy/tests/reader_tests/test_virr_l1b.py 97.39% <100%> (+0.19%) ⬆️
satpy/readers/virr_l1b.py 98.5% <100%> (+0.09%) ⬆️
satpy/scene.py 90.47% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebede6d...445dcff. Read the comment docs.

@djhoese djhoese merged commit fcd5d88 into pytroll:master Aug 30, 2019
@djhoese djhoese deleted the feature-virr-coeffs branch August 30, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants