Cache slicing arrays in bilinear resampler #897
Conversation
pnuu
added
component:resampling
enhancement
If old cache exist with the *exact* filename, it means that either something failed the last time the caches were being saved, or there were older incompatible caches present. So better to move them out of the way before trying to save.
|
I'm at a loss with the failing test. The same test works locally as expected, but not on either of Travis or Appveyor. Any ideas? |
|
Could it be that the zarr file is already present due to some other test and that the conversion is skipped ? Just a wild guess... |
|
The failing test has its own different |
|
The bottom of the failing tests (during the behavior tests) says that |
|
Hmph. I guess the CI services do not respect what's listed in |
|
Nope, same failure. |
|
Well the travis behavior tests are passing now. I'll see if I notice anything in the code. |
|
Python 2.7 is failing because "FileExistsError" does not exist. |
The filenames were different because of different kwargs. Now the filenames are not hardcoded but are created with identical calls.
Codecov Report
@@ Coverage Diff @@
## master #897 +/- ##
=========================================
+ Coverage 84.83% 84.9% +0.07%
=========================================
Files 171 171
Lines 25232 25299 +67
=========================================
+ Hits 21405 21480 +75
+ Misses 3827 3819 -8
Continue to review full report at Codecov.
|
|
It was indeed the filenames. The filenames I had created had slightly different |
For bilinear interpolation, this PR caches the slicing arrays (for data and masking) instead of the
valid_input_indexandindex_array, from which the current version would always re-calculate these slicing arrays.Also, instead of using
da.from_zarr()to load the cache, direct use ofzarrseems to make a big difference in speed. When/if someone makes the effort to completely daskify the bilinear resampling, this change might need to be reverted.flake8 satpy