Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HRV area definition tests #903

Merged
merged 5 commits into from Sep 16, 2019
Merged

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Sep 16, 2019

Some tests were failing with the newer pyproj.

The main problem was that pyproj is now converting floats to ints when possible for the projection parameters, hence triggering some errors.

  • Tests passed
  • Passes flake8 satpy

@mraspaud mraspaud added enhancement code enhancements, features, improvements component:readers labels Sep 16, 2019
@mraspaud mraspaud self-assigned this Sep 16, 2019
@codecov
Copy link

codecov bot commented Sep 16, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@0f76aea). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #903   +/-   ##
=========================================
  Coverage          ?   84.84%           
=========================================
  Files             ?      171           
  Lines             ?    25297           
  Branches          ?        0           
=========================================
  Hits              ?    21464           
  Misses            ?     3833           
  Partials          ?        0
Impacted Files Coverage Δ
satpy/tests/reader_tests/test_seviri_l1b_hrit.py 98.91% <100%> (ø)
satpy/tests/test_config.py 87.34% <100%> (ø)
satpy/readers/utils.py 75.23% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f76aea...c9f7f2f. Read the comment docs.

@mraspaud mraspaud marked this pull request as ready for review September 16, 2019 08:56
Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should h be converted to float here as well? https://github.com/pytroll/satpy/blob/master/satpy/readers/utils.py#L138

And one nitpick: Maybe it would be more clear to explicitly convert the proj dict items to float instead of dividing them by 1000. .

satpy/tests/test_config.py Show resolved Hide resolved
satpy/readers/utils.py Outdated Show resolved Hide resolved
@mraspaud mraspaud merged commit 1389229 into pytroll:master Sep 16, 2019
@mraspaud mraspaud deleted the fix-hrit-tests branch September 16, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants