Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update orbit coefficient docstrings in seviri_l1b_hrit #916

Merged
merged 1 commit into from Sep 30, 2019

Conversation

sfinkens
Copy link
Member

@sfinkens sfinkens commented Sep 30, 2019

A while ago we were wondering how there can be gaps and overlaps in the list of orbit coefficients in the HRIT header. Now I got a reply from the EUMETSAT Help Desk:

A manoeuvre is a discontinuity in the orbit parameters. The flight dynamic algorithms are not made to interpolate over the time-span of the manoeuvre; hence we have elements describing the orbit before a manoeuvre and a new set of elements describing the orbit after the manoeuvre.
The flight dynamic products are created so that there is an intentional gap at the time of the manoeuvre. In your example that’s between 22:15 and 22:30. This is achieved by setting the validity-end-time of the last pre-manoeuvre elements to hh:00, hh:15, hh:30 or hh:45 before the manoeuvre. Each set of elements spans six hours. In your example the validity-end-time was set to 22:15 and hence the validity-start-time is 16:15. Now, the overlap is not of an issue as both sets of elements describe the same pre-manoeuvre orbit (with negligible variations).
This mechanism is in place for all MSG satellites since the beginning and still is used like this.

I updated the docstrings accordingly.

  • Tests passed
  • Passes flake8 satpy
  • Fully documented

@sfinkens sfinkens changed the title Update docstrings for orbit coefficients in seviri_l1b_hrit Update docstrings for orbit coefficients in seviri_l1b_hrit Sep 30, 2019
@sfinkens sfinkens changed the title Update docstrings for orbit coefficients in seviri_l1b_hrit Update docstrings for orbit coefficients in seviri_l1b_hrit Sep 30, 2019
@sfinkens sfinkens changed the title Update docstrings for orbit coefficients in seviri_l1b_hrit Update orbit coefficient docstrings in seviri_l1b_hrit Sep 30, 2019
@sfinkens sfinkens marked this pull request as ready for review September 30, 2019 09:16
@coveralls
Copy link

coveralls commented Sep 30, 2019

Coverage Status

Coverage increased (+0.004%) to 85.366% when pulling ac32121 on sfinkens:doc-seviri-hrit-orbit-coefs into 24dd827 on pytroll:master.

@codecov
Copy link

codecov bot commented Sep 30, 2019

Codecov Report

Merging #916 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #916   +/-   ##
=======================================
  Coverage   85.36%   85.36%           
=======================================
  Files         174      174           
  Lines       25912    25912           
=======================================
  Hits        22119    22119           
  Misses       3793     3793
Impacted Files Coverage Δ
satpy/readers/seviri_l1b_hrit.py 92.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24dd827...ac32121. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud added this to the v0.17.0 milestone Sep 30, 2019
@mraspaud mraspaud merged commit d09edbc into pytroll:master Sep 30, 2019
@sfinkens sfinkens deleted the doc-seviri-hrit-orbit-coefs branch October 1, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants