Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the olci l2 mask a bool array instead of floats #923

Merged
merged 2 commits into from Oct 8, 2019

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Oct 4, 2019

  • Tests added and test suite added to parent suite
  • Tests passed
  • Passes flake8 satpy

@mraspaud mraspaud self-assigned this Oct 4, 2019
@mraspaud mraspaud added the bug label Oct 4, 2019
@mraspaud
Copy link
Member Author

mraspaud commented Oct 4, 2019

@JohannesSMHI you might want to take a look at this.

@coveralls
Copy link

coveralls commented Oct 4, 2019

Coverage Status

Coverage increased (+0.01%) to 85.364% when pulling 21e44fb on mraspaud:fix-olci-mask into 95b0aea on pytroll:master.

@codecov
Copy link

codecov bot commented Oct 4, 2019

Codecov Report

Merging #923 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #923      +/-   ##
==========================================
+ Coverage   85.35%   85.36%   +0.01%     
==========================================
  Files         174      174              
  Lines       26037    26053      +16     
==========================================
+ Hits        22223    22240      +17     
+ Misses       3814     3813       -1
Impacted Files Coverage Δ
satpy/tests/reader_tests/test_olci_nc.py 94.28% <100%> (+1.06%) ⬆️
satpy/readers/olci_nc.py 48.33% <100%> (+4.9%) ⬆️
satpy/readers/__init__.py 93.07% <0%> (-1.21%) ⬇️
satpy/scene.py 90.47% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95b0aea...21e44fb. Read the comment docs.

@mraspaud mraspaud marked this pull request as ready for review October 8, 2019 12:02
@mraspaud mraspaud requested a review from djhoese as a code owner October 8, 2019 12:02
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing seems unreasonable here. A little confused by how this format is structured, but the code makes sense.

Is % 2 equivalent to & 0b11?

Edit: Or maybe 0b01?

@mraspaud
Copy link
Member Author

mraspaud commented Oct 8, 2019

yes it's equivalent, haven't checked the performance though.

@mraspaud mraspaud merged commit 9444383 into pytroll:master Oct 8, 2019
@mraspaud mraspaud deleted the fix-olci-mask branch October 8, 2019 15:39
@mraspaud mraspaud added this to the v0.17.1 milestone Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants