Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resampler imports #927

Merged
merged 2 commits into from Oct 8, 2019
Merged

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Oct 8, 2019

This PR moves the pyresample resampler imports inside the methods they are used. In this way users won't be forced to upgrade pyresample if they don't need newer resamplers and features.

NOTE: for bilinear interpolation the pyresample upgrade is still necessary, and so is if bucket resampler is needed. The default nearest resampler will work as expected also with older (< 1.13.0) pyresample versions without forcing an update.

@pnuu pnuu requested a review from djhoese October 8, 2019 13:04
@pnuu pnuu requested a review from mraspaud as a code owner October 8, 2019 13:04
@pnuu pnuu self-assigned this Oct 8, 2019
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mraspaud mraspaud added component:resampling enhancement code enhancements, features, improvements labels Oct 8, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 85.348% when pulling b4acd1b on pnuu:fix-resampler-imports into 95b0aea on pytroll:master.

@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #927 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #927   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files         174      174           
  Lines       26037    26037           
=======================================
  Hits        22223    22223           
  Misses       3814     3814
Impacted Files Coverage Δ
satpy/tests/test_resample.py 98.37% <100%> (ø) ⬆️
satpy/resample.py 92.97% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95b0aea...b4acd1b. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 56909b7 into pytroll:master Oct 8, 2019
@mraspaud mraspaud added this to the v0.17.1 milestone Oct 8, 2019
@pnuu pnuu deleted the fix-resampler-imports branch October 9, 2019 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:resampling enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

satpy 0.17 does not work with pyresample 1.11
4 participants