Update coord2area_def.py #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #931 +/- ##
==========================================
+ Coverage 85.41% 87.33% +1.92%
==========================================
Files 172 188 +16
Lines 26046 28624 +2578
==========================================
+ Hits 22246 24999 +2753
+ Misses 3800 3625 -175
Continue to review full report at Codecov.
|
mraspaud
requested changes
Oct 9, 2019
utils/coord2area_def.py
Outdated
| os.environ['PPP_CONFIG_DIR'] = '/my_local_path/for_satpy_configuration' | ||
|
|
||
| As a further functionality this script may give a quick display of the defined area, | ||
| provided the path for the GSHHG library is supplied via the "-s" option. |
There was a problem hiding this comment.
It should maybe be mentioned that pycoast, pillow and aggdraw need to be installed also for this functionality to work.
There was a problem hiding this comment.
Just done. Thanks for the suggestion!
AppLEaDaY
commented
Oct 26, 2019
utils/coord2area_def.py
Outdated
| os.environ['PPP_CONFIG_DIR'] = '/my_local_path/for_satpy_configuration' | ||
|
|
||
| As a further functionality this script may give a quick display of the defined area, | ||
| provided the path for the GSHHG library is supplied via the "-s" option. |
There was a problem hiding this comment.
Just done. Thanks for the suggestion!
mraspaud
approved these changes
Dec 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coord2area_def.py update
Adjusted commented text to point to the output actually supplied nowadays (yaml format and not the old format).
Added instruction in commented text concerning how to display the defined area relying on gshhs library.
Removed unused commented lines.