Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MultiScene.save_animation to work with new dask.distributed versions #938

Merged
merged 2 commits into from Oct 17, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Oct 14, 2019

New-ish versions of dask do not allow the distributed Client to be used the way I had originally programmed save_animation to use it. This PR fixes it to work with newer versions of dask and also updates the tests to use the real distributed Client to avoid this problem in the future.

  • Tests added and test suite added to parent suite
  • Tests passed
  • Passes flake8 satpy

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 85.407% when pulling 8a4e63a on djhoese:bugfix-save-animation-distributed into a6ce4df on pytroll:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 85.407% when pulling 8a4e63a on djhoese:bugfix-save-animation-distributed into a6ce4df on pytroll:master.

@codecov
Copy link

codecov bot commented Oct 14, 2019

Codecov Report

Merging #938 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #938      +/-   ##
=========================================
- Coverage   85.41%   85.4%   -0.01%     
=========================================
  Files         172     172              
  Lines       26046   26046              
=========================================
- Hits        22246   22245       -1     
- Misses       3800    3801       +1
Impacted Files Coverage Δ
satpy/tests/test_multiscene.py 97.84% <100%> (ø) ⬆️
satpy/multiscene.py 89.13% <100%> (ø) ⬆️
satpy/scene.py 90.35% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ce4df...8a4e63a. Read the comment docs.

@djhoese djhoese merged commit d0484de into pytroll:master Oct 17, 2019
@djhoese djhoese deleted the bugfix-save-animation-distributed branch October 17, 2019 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants