Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MERSI-2 natural_color composite using the wrong band for sharpening #939

Merged
merged 4 commits into from Oct 17, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Oct 15, 2019

The ratio sharpening compositor uses the optional (4th) prerequisite as the high resolution band. For MERSI-2's natural_color composite I had the high/low res green bands swapped. Band 4 is the high res and should be optional, band 15 is the low res and should be the required. This should have minimal different on the red and blue bands but is should replace the green band in the final output with the higher resolution band 4 image.

  • Tests added and test suite added to parent suite
  • Tests passed
  • Passes flake8 satpy

@djhoese djhoese added the bug label Oct 15, 2019
@djhoese djhoese self-assigned this Oct 15, 2019
@djhoese
Copy link
Member Author

djhoese commented Oct 15, 2019

Examples created by @kathys with Polar2Grid:

Before

Screen Shot 2019-10-15 at 3 03 22 PM

After

Screen Shot 2019-10-15 at 3 29 54 PM

@coveralls
Copy link

coveralls commented Oct 15, 2019

Coverage Status

Coverage decreased (-0.004%) to 85.407% when pulling 9e91b27 on djhoese:bugfix-mersi-natural into a6ce4df on pytroll:master.

@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #939 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #939      +/-   ##
=========================================
- Coverage   85.41%   85.4%   -0.01%     
=========================================
  Files         172     172              
  Lines       26046   26046              
=========================================
- Hits        22246   22245       -1     
- Misses       3800    3801       +1
Impacted Files Coverage Δ
satpy/readers/nucaps.py 93.71% <0%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ce4df...9e91b27. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djhoese djhoese merged commit 325848a into pytroll:master Oct 17, 2019
@djhoese djhoese deleted the bugfix-mersi-natural branch October 17, 2019 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants