Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to include scale and offset in geotiffs #948

Merged
merged 3 commits into from Oct 24, 2019

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Oct 21, 2019

This PR makes it possible to pass dynamically computed scale and offset to the geotiff writer

  • Tests added and test suite added to parent suite
  • Tests passed
  • Passes flake8 satpy
  • Fully documented

@mraspaud mraspaud self-assigned this Oct 21, 2019
@mraspaud mraspaud added component:writers enhancement code enhancements, features, improvements labels Oct 21, 2019
@coveralls
Copy link

coveralls commented Oct 21, 2019

Coverage Status

Coverage increased (+0.3%) to 86.099% when pulling 6ab34bd on mraspaud:feature-scale-offset-tags into 1a00661 on pytroll:master.

@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #948 into master will increase coverage by 0.26%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #948      +/-   ##
=========================================
+ Coverage   85.83%   86.1%   +0.26%     
=========================================
  Files         172     174       +2     
  Lines       26222   26531     +309     
=========================================
+ Hits        22508   22844     +336     
+ Misses       3714    3687      -27
Impacted Files Coverage Δ
satpy/writers/utils.py 100% <100%> (ø) ⬆️
satpy/writers/geotiff.py 90.56% <100%> (+0.18%) ⬆️
satpy/tests/writer_tests/test_geotiff.py 94.84% <100%> (+0.59%) ⬆️
satpy/tests/writer_tests/test_ninjotiff.py 97.72% <100%> (+0.1%) ⬆️
satpy/writers/ninjotiff.py 59.37% <71.42%> (+12.4%) ⬆️
satpy/tests/compositor_tests/test_viirs.py 98.71% <0%> (-0.59%) ⬇️
satpy/composites/ahi.py 100% <0%> (ø) ⬆️
satpy/tests/reader_tests/test_ami_l1b.py 94.73% <0%> (ø)
satpy/readers/ami_l1b.py 97.32% <0%> (ø)
satpy/tests/compositor_tests/__init__.py 99.57% <0%> (+0.02%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a00661...6ab34bd. Read the comment docs.

@mraspaud mraspaud marked this pull request as ready for review October 24, 2019 18:49
@mraspaud mraspaud merged commit 2960285 into pytroll:master Oct 24, 2019
@mraspaud mraspaud deleted the feature-scale-offset-tags branch October 24, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:writers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants