Fix HDF4 handling of scalar attributes #969
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is caused by a new version of numpy, changes to the dtype handling that I did a while back in the HDF4 file handler, or something else. The HDF4 utility file handler is returning all attributes as numpy arrays even if they are scalar attributes. This PR should fix this.
The other option I thought about doing is adding an if statement earlier in the attribute function that checks if the data isn't a numpy array then don't touch it. I'm not sure if this would be good or bad.
flake8 satpy