Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factorize area computation in hrit_jma #978

Merged
merged 2 commits into from Dec 6, 2019
Merged

Factorize area computation in hrit_jma #978

merged 2 commits into from Dec 6, 2019

Conversation

sfinkens
Copy link
Member

@sfinkens sfinkens commented Nov 26, 2019 •
edited by mraspaud

@sfinkens sfinkens self-assigned this Nov 26, 2019
@sfinkens sfinkens added component:readers enhancement code enhancements, features, improvements labels Nov 26, 2019
@sfinkens sfinkens added this to Planned in PCW Copenhagen 2019 via automation Nov 26, 2019
@sfinkens sfinkens moved this from Planned to Needs review in PCW Copenhagen 2019 Nov 26, 2019
@coveralls
Copy link

coveralls commented Nov 26, 2019 •
edited

Coverage Status

Coverage decreased (-0.0007%) to 86.864% when pulling 5373dcf on sfinkens:factorize-area-hrit-jma into 177d150 on pytroll:master.

@codecov
Copy link

codecov bot commented Nov 26, 2019 •
edited

Codecov Report

Merging #978 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #978      +/-   ##
==========================================
- Coverage   86.86%   86.86%   -0.01%     
==========================================
  Files         181      181              
  Lines       27461    27452       -9     
==========================================
- Hits        23854    23846       -8     
+ Misses       3607     3606       -1
Impacted Files Coverage Δ
satpy/readers/hrit_jma.py 99.15% <100%> (+0.7%) ⬆️
satpy/tests/reader_tests/test_ahi_hrit.py 96.72% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 177d150...5373dcf. Read the comment docs.

mraspaud
mraspaud approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for removing code :)

PCW Copenhagen 2019 automation moved this from Needs review to In progress Nov 27, 2019
djhoese
djhoese approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfinkens sfinkens moved this from In progress to Done in PCW Copenhagen 2019 Nov 28, 2019
@mraspaud mraspaud merged commit 8831c03 into pytroll:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraspaud mraspaud mraspaud approved these changes

@djhoese djhoese djhoese approved these changes

Assignees

@sfinkens sfinkens

Labels
component:readers enhancement code enhancements, features, improvements
Projects
PCW Copenhagen 2019
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Factorize area def computation in jma_hrit
4 participants
@sfinkens @coveralls @mraspaud @djhoese