Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read the meta_data dictionary from pygac #980

Merged
merged 4 commits into from Dec 6, 2019

Conversation

ninahakansson
Copy link
Contributor

@ninahakansson ninahakansson commented Nov 26, 2019

Read meta_data attribute from pygac

  • Tests passed
  • Passes flake8 satpy
  • Fully documented
  • Wait for pygac > 1.2.1

@coveralls
Copy link

coveralls commented Nov 26, 2019

Coverage Status

Coverage increased (+0.0005%) to 86.865% when pulling 949e368 on ninahakansson:read_pygac_meta_data into 177d150 on pytroll:master.

@codecov
Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #980 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #980      +/-   ##
==========================================
- Coverage   86.86%   86.86%   -0.01%     
==========================================
  Files         181      181              
  Lines       27461    27462       +1     
==========================================
  Hits        23854    23854              
- Misses       3607     3608       +1
Impacted Files Coverage Δ
satpy/readers/avhrr_l1b_gaclac.py 94.85% <100%> (ø) ⬆️
satpy/tests/reader_tests/test_avhrr_l1b_gaclac.py 97.98% <100%> (+0.01%) ⬆️
satpy/scene.py 90.35% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 177d150...949e368. Read the comment docs.

@ninahakansson ninahakansson changed the title Read the meta_data dictionary from pygac if available Read the meta_data dictionary from pygac Nov 27, 2019
@ninahakansson ninahakansson marked this pull request as ready for review December 5, 2019 20:41
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud added component:readers enhancement code enhancements, features, improvements labels Dec 6, 2019
@mraspaud mraspaud merged commit ccc2e96 into pytroll:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants