Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HRV full disk navigation for seviri_l1b_native-reader #985

Conversation

ameraner
Copy link
Member

PR implements the navigation for the SEVIRI HRV full disk case in the Native format reader.
The HRV channel covers two separated geographical areas; when ordering the full disk data, the two areas are stacked together and need to be navigated to the original correct geolocations by reading the correspondent metadata and defining two area_definitions. This is now implemented for the Native reader, which now covers all data order combinations.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the much needed work with HRV!

@coveralls
Copy link

coveralls commented Nov 29, 2019

Coverage Status

Coverage increased (+0.02%) to 86.887% when pulling 68ec7d2 on ameraner:seviri_hrv_full_disk_navigation_for_native_reader into 177d150 on pytroll:master.

@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #985 into master will increase coverage by 0.02%.
The diff coverage is 92.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #985      +/-   ##
==========================================
+ Coverage   86.86%   86.88%   +0.02%     
==========================================
  Files         181      181              
  Lines       27461    27499      +38     
==========================================
+ Hits        23854    23893      +39     
+ Misses       3607     3606       -1
Impacted Files Coverage Δ
satpy/tests/reader_tests/test_seviri_l1b_native.py 93.6% <100%> (+0.27%) ⬆️
satpy/readers/seviri_l1b_native.py 71.64% <87.87%> (+4.4%) ⬆️
satpy/scene.py 90.35% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 177d150...68ec7d2. Read the comment docs.

satpy/readers/seviri_l1b_native.py Outdated Show resolved Hide resolved
satpy/readers/seviri_l1b_native.py Outdated Show resolved Hide resolved
satpy/readers/seviri_l1b_native.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_seviri_l1b_native.py Outdated Show resolved Hide resolved
satpy/readers/seviri_l1b_native.py Outdated Show resolved Hide resolved
satpy/readers/seviri_l1b_native.py Outdated Show resolved Hide resolved
satpy/readers/seviri_l1b_native.py Outdated Show resolved Hide resolved
satpy/readers/seviri_l1b_native.py Outdated Show resolved Hide resolved
…RV and VISIR geometric properties definition.
@ameraner ameraner requested a review from sjoro November 29, 2019 11:52
@ameraner
Copy link
Member Author

Added a new commit responding to Sauli's review.

satpy/readers/seviri_l1b_native.py Outdated Show resolved Hide resolved
@sjoro sjoro changed the title Seviri hrv full disk navigation for native reader Add SEVIRI HRV full disk navigation for native reader Nov 29, 2019
@sjoro sjoro changed the title Add SEVIRI HRV full disk navigation for native reader Add SEVIRI HRV full disk navigation for seviri_l1b_native-reader Nov 29, 2019
@sjoro sjoro changed the title Add SEVIRI HRV full disk navigation for seviri_l1b_native-reader Add HRV full disk navigation for seviri_l1b_native-reader Nov 29, 2019
@ameraner ameraner requested a review from sjoro November 29, 2019 12:45
Copy link
Collaborator

@sjoro sjoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you @ameraner for this much needed feature!

@sjoro sjoro added component:readers enhancement code enhancements, features, improvements labels Nov 29, 2019
@mraspaud mraspaud merged commit afdbe56 into pytroll:master Dec 6, 2019
@ameraner ameraner deleted the seviri_hrv_full_disk_navigation_for_native_reader branch December 7, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HRV navigation to seviri_l1b_native-reader
4 participants