Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generation of solar and satellite angles when lon/lats are invalid #989

Merged
merged 3 commits into from Dec 3, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Dec 2, 2019

This fixes the angle generation for the various compositors/modifiers that use the get_angles() functions so they actually check that the lon/lat degrees are valid. This should have been done for a long time since 1e30s were getting through all of the processing. Now in pyproj 2.4.2 these invalid values are infinity and this was causing some tests to fail.

This should probably have more tests added.

  • Tests added and test suite added to parent suite
  • Tests passed
  • Passes flake8 satpy

@djhoese djhoese changed the title Empty commit for testing Fix generation of solar and satellite angles when lon/lats are invalid Dec 3, 2019
@djhoese djhoese self-assigned this Dec 3, 2019
@djhoese djhoese added the bug label Dec 3, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 86.877% when pulling bd8619e on djhoese:debug-travis into 177d150 on pytroll:master.

@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #989 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #989      +/-   ##
==========================================
+ Coverage   86.86%   86.87%   +0.01%     
==========================================
  Files         181      181              
  Lines       27461    27487      +26     
==========================================
+ Hits        23854    23880      +26     
  Misses       3607     3607
Impacted Files Coverage Δ
satpy/composites/__init__.py 78.36% <100%> (+0.05%) ⬆️
satpy/tests/compositor_tests/__init__.py 99.58% <100%> (ø) ⬆️
satpy/composites/viirs.py 83.85% <100%> (+0.07%) ⬆️
satpy/tests/compositor_tests/test_viirs.py 99.06% <100%> (+0.35%) ⬆️
satpy/scene.py 90.35% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 177d150...bd8619e. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just have some more abstract questions

satpy/tests/compositor_tests/test_viirs.py Show resolved Hide resolved
satpy/composites/viirs.py Show resolved Hide resolved
satpy/tests/compositor_tests/test_viirs.py Show resolved Hide resolved
@djhoese djhoese merged commit b286885 into pytroll:master Dec 3, 2019
@djhoese djhoese deleted the debug-travis branch December 3, 2019 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants