Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FCI L1C reader short and long name metadata #999

Merged
merged 2 commits into from Dec 6, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Dec 4, 2019

Adds short_name, long_name, and a longer description for the FCI reader. This is so GUI applications like my SIFT tool can display a "prettier" name for this reader.

@djhoese
Copy link
Member Author

djhoese commented Dec 4, 2019

@gerritholl FYI ^

@coveralls
Copy link

coveralls commented Dec 4, 2019

Coverage Status

Coverage increased (+0.01%) to 86.893% when pulling 6e986a0 on djhoese:feature-fci-reader-metadata into 071e34b on pytroll:master.

@codecov
Copy link

codecov bot commented Dec 4, 2019

Codecov Report

Merging #999 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #999      +/-   ##
==========================================
- Coverage   86.89%   86.89%   -0.01%     
==========================================
  Files         181      181              
  Lines       27497    27497              
==========================================
- Hits        23894    23893       -1     
- Misses       3603     3604       +1
Impacted Files Coverage Δ
satpy/scene.py 90.35% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 071e34b...6e986a0. Read the comment docs.

@gerritholl
Copy link
Collaborator

As far as I'm concerned we don't need the word "generic". I think it's not meaningful. A generic FCI L1C reader would read both FDHSI and HRFI.

@djhoese
Copy link
Member Author

djhoese commented Dec 5, 2019

Ok i reworded it based on the comments here and on slack.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit cf17adf into pytroll:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants