Refactor colormap creation #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Started work on refactoring colormap creation. Move some functionality from Satpy to here. Deprecate passing a string containing a CSV to ``Colormap.from_file``, this should now use ``Colormap.from_string`` instead.
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #117 +/- ##
==========================================
+ Coverage 93.16% 93.36% +0.20%
==========================================
Files 11 11
Lines 3509 3619 +110
==========================================
+ Hits 3269 3379 +110
Misses 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Improve documentation in colormap class and rewrite from_sequence_of_colors in terms of other methods available.
Refactor from_xrda and rename it from_array_with_metadata. This is the method with somewhat funny behaviour that was copied from satpy.composites.ColormapCompositor.build_colormap. It includes some behaviour that I cannot explain, such as cutting off the last value of the colour palette when meanings are not provided. I copied this behaviour as-is from Satpy.
Add a flag to disable the behaviour to remove the last value from the colormap/values.
4 tasks
Fixxing one merge conflict.
mraspaud
approved these changes
Jan 11, 2023
Moved the test-cmap-from-string test method out of the class and changed it into its own function, because it doesn't read from a file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring colormap creation. Move most colormap creation functionality from Satpy to here. Deprecate passing a string containing a CSV to
Colormap.from_file, this should now useColormap.from_stringinstead.There remain some inconsistencies in the API, such as how values are guessed when not explicitly provided, but changing this would affect backward compatibility when coming from Satpy.
This PR also fixes numpy 1.24 compatibility.
git diff origin/master **/*py | flake8 --diff(remove if you did not edit any Python files)