-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor colormap creation #2313
Conversation
Started to work on refactoring colormap creation. Move functionality to trollimage where appropriate and in particular where it's duplicated. Still a work in progress.
Move functionality from ColormapCompositor.build_colormap to trollimage
Since this depends on new features in trollimage, I think we should set the min version of trollimage in setup.py accordingly, right? |
Fix the trollimage dependency to require at least 1.20, due to the colormap refactoring.
Changed trollimage version to 1.20 in 24db9d3. |
Codecov Report
@@ Coverage Diff @@
## main #2313 +/- ##
==========================================
+ Coverage 94.36% 94.59% +0.22%
==========================================
Files 310 314 +4
Lines 46641 47484 +843
==========================================
+ Hits 44014 44916 +902
+ Misses 2627 2568 -59
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
codecov would seem to be confused, but considering I removed tested code, it's plausible that the total code coverage goes down |
Just waiting on a conda-forge release before we merge this |
Refactor colormap creation. Move functionality to trollimage where appropriate, and in particular where it's duplicated.
Bump trollimage version to 1.20 due to the requirement of pytroll/trollimage#117.