Fix casting and scaling float arrays in finalize #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another bug found. If you use finalize on an RGBA array represented by floats it wasn't casting it to the output data type which was causing an error by rasterio. Additionally, it wasn't being scaled because it already had an alpha channel.
This should all be fixed now so all float input gets scaled to the output data range regardless of mode and is assumed to be between 0 and 1. All integer input data is left as is and is assumed to be the expected values. Any integer values that don't fit in the output data type are clipped. I've tried adding all this information to the docstring for finalize as well.
git diff origin/master **/*py | flake8 --diff
(remove if you did not edit any Python files)