-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide conda-forge package #9
Comments
Branch itk5 is fully functional. It works with 5.1.2. Please let me know if
you encounter any issues.
On Mon, May 31, 2021 at 5:16 AM Ghislain Antony Vaillant < ***@***.***> wrote:
What's the statuts of (and work remaining for) porting Convert3D to ITK
version 5?
I can see some initial work on the itk5 branch and a pending PR #8
<#8>.
I'd be happy to help.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJPEW2RISFC6XLUIRWESYLTQNHXRANCNFSM452QFQRQ>
.
--
Paul A. Yushkevich, Ph.D.
Professor of Radiology
Penn Image Computing and Science Laboratory
University of Pennsylvania Perelman School of Medicine
|
I am trying to build a conda-forge package for convert3d and only ITK 5 is available hence my request. So far, I am stuck with the Have you got any plans to merge it to the main branch at some point and tag a new release? |
Hi Ghislain
Having c3d in conda would be great, and if you could also do the same four
our greedy registration tool (https://github.com/pyushkevich/greedy),
that would be great too.
I added a CMake option CONVERT3D_USE_ITK_REMOTE_MODULES (which is ON by
default). If you set it to OFF, it will no longer look for ITK remote
modules. I also merged itk5 branch into the main one.
Thanks,
Paul
…On Wed, Jun 2, 2021 at 5:32 AM Ghislain Antony Vaillant < ***@***.***> wrote:
I am trying to build a conda-forge package for convert3d and only ITK 5 is
available hence my request.
So far, I am stuck with the MorphologicalContourInterpolation dependency
which is not available right now. It is still a ITK Remote module and they
are not built by default on conda-forge.
Have you got any plans to merge it to the main branch at some point and
tag a new release?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJPEWZPCOKJYSZD7CK5XATTQX3ERANCNFSM452QFQRQ>
.
--
Paul A. Yushkevich, Ph.D.
Professor of Radiology
Penn Image Computing and Science Laboratory
University of Pennsylvania Perelman School of Medicine
|
Brilliant. Thank you so much. Progress on the conda-forge package is here btw: |
@pyushkevich fyi, you've got a few deprecated usage of VNL:
|
There is also an occurrence of: Aren't FFT features provided by ITK in your case? |
Apart from that, the binaries build fine on the conda-forge infrastructure so we are quite close modulo the overlinking issue. |
Hi, just pushed a commit removing the FFTW line from CMakeLists
Thanks!
…On Wed, Jun 2, 2021 at 10:06 AM Ghislain Antony Vaillant < ***@***.***> wrote:
Apart from that, the binaries build fine on the conda-forge infrastructure
so we are quite close modulo the overlinking issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJPEW2Y72QHJ3TEKRFTA7TTQY3GLANCNFSM452QFQRQ>
.
--
Paul A. Yushkevich, Ph.D.
Professor of Radiology
Penn Image Computing and Science Laboratory
University of Pennsylvania Perelman School of Medicine
|
Actually, you've got and explicit dependency on FFTW here. |
Thanks, I missed that. The file is not used, and I just pushed a commit
deleting it.
…On Wed, Jun 2, 2021 at 5:53 PM Ghislain Antony Vaillant < ***@***.***> wrote:
Actually, you've got and explicit dependency on FFTW here
<https://github.com/pyushkevich/c3d/blob/master/adapters/SimpleElasticRegistration.h>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJPEW2ZHEDWJ2YKL633WCDTQ2R5ZANCNFSM452QFQRQ>
.
--
Paul A. Yushkevich, Ph.D.
Professor of Radiology
Penn Image Computing and Science Laboratory
University of Pennsylvania Perelman School of Medicine
|
Thanks, I am rebasing the package onto your latest commit. Do you want to be added as co-maintainer of the conda-forge repo? |
Thanks, sure, I don't really know how to package stuff for conda though.
…On Thu, Jun 3, 2021 at 10:54 AM Ghislain Antony Vaillant < ***@***.***> wrote:
Thanks, I am rebasing the package onto your latest commit.
Do you want to be added as co-maintainer of the conda-forge repo?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJPEW3PDNYIRL5FQWM3OETTQ6JQVANCNFSM452QFQRQ>
.
--
Paul A. Yushkevich, Ph.D.
Professor of Radiology
Penn Image Computing and Science Laboratory
University of Pennsylvania Perelman School of Medicine
|
That's the nice thing, once it's done the only maintenance effort is just
merging software upgrade PRs proposed by the conda-forge CI.
Le jeu. 3 juin 2021 à 19:21, Paul Yushkevich ***@***.***> a
écrit :
… Thanks, sure, I don't really know how to package stuff for conda though.
On Thu, Jun 3, 2021 at 10:54 AM Ghislain Antony Vaillant <
***@***.***> wrote:
> Thanks, I am rebasing the package onto your latest commit.
>
> Do you want to be added as co-maintainer of the conda-forge repo?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#9 (comment)>, or
> unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAJPEW3PDNYIRL5FQWM3OETTQ6JQVANCNFSM452QFQRQ
>
> .
>
--
Paul A. Yushkevich, Ph.D.
Professor of Radiology
Penn Image Computing and Science Laboratory
University of Pennsylvania Perelman School of Medicine
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAO7U33I4GPT4DW2EZY5JP3TQ62ZXANCNFSM452QFQRQ>
.
|
The conda-forge package is ready for review. @pyushkevich would you mind tagging the current version of the code with a new one (v1.3.0?) so I can reference a proper release tarball in the conda-forge recipe? Cheers. |
Thanks, Ghislain!
I just tagged v1.3.0 and pushed the tag.
…On Mon, Jun 7, 2021 at 12:25 PM Ghislain Antony Vaillant < ***@***.***> wrote:
The conda-forge package is ready for review. @pyushkevich
<https://github.com/pyushkevich> would you mind tagging the current
version of the code with a new one (v1.3.0?) so I can reference a proper
release tarball in the conda-forge recipe?
Cheers.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJPEW2MR7XAXXTX4WFAOJTTRTXHZANCNFSM452QFQRQ>
.
--
Paul A. Yushkevich, Ph.D.
Professor of Radiology
Penn Image Computing and Science Laboratory
University of Pennsylvania Perelman School of Medicine
|
I check the conda-forge recipe, and found:
so, why not add
to |
Forgot to close this issue. A conda package has been available for a while now. |
What's the statuts of (and work remaining for) porting Convert3D to ITK version 5?
I can see some initial work on the
itk5
branch and a pending PR #8.I'd be happy to help.
The text was updated successfully, but these errors were encountered: