Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download the list of members from Google Spreadsheet, download avatars as files #85

Open
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@honzajavorek
Copy link
Member

commented Jun 25, 2019

This change introduces a new separate step needed for development and deployment of the site - pipenv run build, which downloads data from external sources. Even though the site is serialized into a static HTML so one might think doing it in Flask views is not a problem, I think this is a better solution, because I can run pipenv run build just once and then develop the site with fast refreshing or even offline.

In this PR I introduce downloading of members list from a spreadsheet saved in Pyvec Google Drive. It updates the board members according to the latest changes. When I was at it, I also moved all avatar handling into the build step - no more proxy views to make thumbnails etc. Now all avatars are downloaded to a directory inside static as PNG images during the build step.

@honzajavorek honzajavorek requested a review from pyvec/pyvec-org Jun 25, 2019

@honzajavorek honzajavorek force-pushed the honzajavorek/members branch from df199cb to 6636d00 Jun 25, 2019

Show resolved Hide resolved README.md
update the translation of "board"
Even though it is still the same thing, with o.s. it was called "rada", with z.s. it is called "výbor"
@hroncok

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

I can check the rest within a week. Let me know if that's to late for you

@honzajavorek

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2019

I want to have the site ready for 100th Prague Pyvo and before the summer sprint. Going to bike over the weekend, so I think ~week should be okay. I'm working on another, parallel, but significantly smaller PR which I'll issue promptly.

@hroncok
Copy link
Member

left a comment

Could this be a little bit more verbose?

$ pipenv run build
Loading .env environment variables…
### Members

Pyvec members are tracked in an internal Google Spreadsheet. The future
intention is to have the list of members public, but we're not there yet (GDPR).

This comment has been minimized.

Copy link
@hroncok

hroncok Jun 27, 2019

Member
Suggested change
intention is to have the list of members public, but we're not there yet (GDPR).
intention is to have the list of members public, but we're not there yet.


def generate_yaml(data):
yaml_contents = '''\

This comment has been minimized.

Copy link
@hroncok

hroncok Jun 27, 2019

Member

consider using textwrap.dedent instead. Or not, it's just a tip.

@honzajavorek

This comment has been minimized.

Copy link
Member Author

commented Jul 1, 2019

Note: according to bylaws the list of members should contain a date of birth, which I wouldn't like to leak for anyone, it's over my limits of what can be secured by security by obscurity and what cannot.

This needs to be reworked into something using Google API to access a private Google document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.