Series page: Add pagination #52
Conversation
|
The checks fail saying some URL is unreachable, though I haven't been yet able to find out why exactly. I'll try to do so soon. |
|
Your code assumes there's a meetup in the current year. The test data doesn't include such a meetup. |
pyvocz/views.py
Outdated
| organizer_info=organizer_info) | ||
| return render_template('series.html', series=series, today=today, year=year, | ||
| organizer_info=organizer_info, first_year=first_year, | ||
| last_year=last_year, series_slug=series_slug) |
There was a problem hiding this comment.
Passing series_slug is unnsecessary; you can use series.slug.
| year=last_year if year==None else year-1) }}">></a> | ||
| </li> | ||
| </ul> | ||
| </div> |
There was a problem hiding this comment.
Please use a local macro instead. In series.html, you can write:
{% macro pagination() %}
<div>
...
</div>
{% endmacro %}
and then use it as {{ pagination() }}.
The "fragments" are an embarassing artefact from a time when I didn't know about macros. (I wrote commits to get rid of them, but didn't submit them yet as I don't want to conflict with this work.)
pyvocz/views.py
Outdated
| @route('/<series_slug>/') | ||
| def series(series_slug): | ||
| @route('/<series_slug>/', defaults={'year': None}) | ||
| @route('/<series_slug>/<int:year>/') |
There was a problem hiding this comment.
I think it would also be useful to have a page that shows all the meetups.
There was a problem hiding this comment.
Oh, I absolutely forgot about that when I was finishing it on the weekend. Will do!
|
I believe I've addressed the code modifications, though I still haven't made progress on the test failure. |
|
Is there a way to run the pyvocz server with the test data so I can see what it's actually doing? |
|
To reproduce this issue, it should be enough to clone https://github.com/pyvec/pyvo-data and remove the meetups for 2017 and 2016 from one of the series. Then pass in the directory with The files used for tests are listed in conftest.py. |
|
So, I think all issues are addressed, tests are passing, and for good measure I made it so years with no events are not displayed as options in the pagination! |
|
Looks pretty good to me, thanks! Deployed. |
Closes issue #8.
I included a refactoring commit to make the subsequent commit's diff easy on the eyes.