Add pueblo.util.proc.process utility
#39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
util-process
branch
2 times, most recently
from
0818116
to
c8a1acc
Compare
amotl
changed the title
pueblo.util.command.process utilitypueblo.util.proc.process utility
It is a wrapper around `subprocess.Popen` to also terminate child processes after exiting.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 75.21% 75.35% +0.13%
==========================================
Files 20 21 +1
Lines 694 710 +16
==========================================
+ Hits 522 535 +13
- Misses 172 175 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This snippet is a wrapper around
subprocess.Popento also terminate child processes after exiting.Source
It has been conceived at
mlflow-cratedb::tests/util.py. There, it takes care of terminating an embedded MLflow instance spawned when running ml training programs in standalone mode.Origin
The code has been shared by @pcattori at https://gist.github.com/jizhilong/6687481#gistcomment-3057122. Thanks!