Skip to content

Commit

Permalink
enforce positive coverage (#1993)
Browse files Browse the repository at this point in the history
* enforce 0% coverage diff

* test coverage reduction causes CI failure

* enforce patch target of 90%

* move untested code

* revert test code
  • Loading branch information
akaszynski committed Jan 2, 2022
1 parent 5828416 commit 6f44c89
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/testing-and-deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,9 @@ jobs:
run: |
xvfb-run pytest -v --cov pyvista --cov-report html
- name: Upload coverage to codecov.io
- uses: codecov/codecov-action@v2
if: matrix.python-version == '3.8'
run: bash <(curl -s https://codecov.io/bash)
name: 'Upload coverage to CodeCov'

- name: Check package
run: |
Expand Down
18 changes: 16 additions & 2 deletions codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,19 @@ comment:

coverage:
status:
project: off
patch: off
project:
default:
# basic
target: 90%
threshold: 0%
# advanced
if_not_found: success
if_ci_failed: error
if_no_uploads: error
patch:
default:
# basic
target: 90%
if_not_found: success
if_ci_failed: error
if_no_uploads: error

0 comments on commit 6f44c89

Please sign in to comment.