Use Set method insted of On and Off method #2769
Labels
good first issue
🍏 low-hanging-fruit
A great issue for first time contributors to get their hands dirty
maintenance
Low-impact maintenance activity
Describe what maintenance you would like added.
Some code uses VTK's
*On()
and*Off()
methods (ex:QuadsOn()
andQuadsOff()
invtkTessellatedBoxSource
class). These generally implement a method calledSet*()
(ex:SetQuads()
), which can be refactored to avoid using if statements.Inspired by @adeak in #2767 (comment)
Links to source code.
You can find it by running
grep "On()" ./pyvista/*/*.py
in root path. For example:pyvista/pyvista/utilities/geometric_objects.py
Lines 675 to 678 in fc9cea7
Pseudocode or Screenshots
Code of Conduct
The text was updated successfully, but these errors were encountered: