Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to newly renamed ipyvtklink #1267

Merged
merged 11 commits into from Apr 15, 2021
Merged

Update to newly renamed ipyvtklink #1267

merged 11 commits into from Apr 15, 2021

Conversation

banesullivan
Copy link
Member

Use the newly renamed ipyvtklink: https://pypi.org/project/ipyvtklink/

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #1267 (fac9209) into master (abd7c37) will decrease coverage by 0.07%.
The diff coverage is 65.00%.

@@            Coverage Diff             @@
##           master    #1267      +/-   ##
==========================================
- Coverage   90.01%   89.94%   -0.08%     
==========================================
  Files          56       56              
  Lines       11305    11354      +49     
==========================================
+ Hits        10176    10212      +36     
- Misses       1129     1142      +13     

@akaszynski akaszynski added this to the 0.30 milestone Apr 14, 2021
Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "works" locally for me, but I'm running into an issue with a frozen window. I'm debugging my instance, but if I can't figure out what's causing it I'll post an issue on the appropriate repo.

@akaszynski
Copy link
Member

This "works" locally for me, but I'm running into an issue with a frozen window. I'm debugging my instance, but if I can't figure out what's causing it I'll post an issue on the appropriate repo.

Turns out it's a local issue. We can merge this and hopefully get a release soon.

docs/conf.py Outdated Show resolved Hide resolved
@banesullivan
Copy link
Member Author

Ready to merge?

@akaszynski
Copy link
Member

Yes. Fire when ready.

@banesullivan banesullivan merged commit 6201fc1 into master Apr 15, 2021
@akaszynski akaszynski deleted the feat/ipyvtklink branch June 24, 2021 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants