Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compute-normals.py #1316

Merged
merged 1 commit into from
May 16, 2021
Merged

Update compute-normals.py #1316

merged 1 commit into from
May 16, 2021

Conversation

RichardScottOZ
Copy link
Contributor

Just all

Overview

Details

  • < feature1 or bug1 description >
  • < feature2 or bug2 description >

@codecov
Copy link

codecov bot commented May 16, 2021

Codecov Report

Merging #1316 (b064567) into master (b446e13) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1316   +/-   ##
=======================================
  Coverage   89.49%   89.49%           
=======================================
  Files          56       56           
  Lines       11464    11464           
=======================================
  Hits        10260    10260           
  Misses       1204     1204           

Copy link
Member

@adeak adeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@adeak
Copy link
Member

adeak commented May 16, 2021

Some tests have been flaky, the failure has nothing to do with the doc change. I'll try close/reopen cycling the PR to trigger a test rerun.

@adeak adeak closed this May 16, 2021
@adeak adeak reopened this May 16, 2021
@adeak adeak merged commit 6d3132b into pyvista:master May 16, 2021
@RichardScottOZ RichardScottOZ deleted the patch-2 branch May 16, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants