Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add trivial module for backwards compatability #1318

Merged
merged 2 commits into from
May 17, 2021

Conversation

akaszynski
Copy link
Member

This PR adds a trivial file to make our recent theme changes compatible with pyvistaqt. I don't want our theme changes to be a breaking change as this needs to be out soon in support of another project https://github.com/pyansys/pymapdl.

@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #1318 (7f9ba5e) into master (9981437) will increase coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1318      +/-   ##
==========================================
+ Coverage   90.03%   90.38%   +0.34%     
==========================================
  Files          56       56              
  Lines       12166    12960     +794     
==========================================
+ Hits        10954    11714     +760     
- Misses       1212     1246      +34     

@akaszynski
Copy link
Member Author

akaszynski commented May 17, 2021

Merging as this is a trivial change.

@akaszynski akaszynski merged commit d6ada7b into master May 17, 2021
@adeak
Copy link
Member

adeak commented May 17, 2021

Out of curiosity, where/how is this new module used in pyvistaqt? I tried looking for theme in that repo but couldn't find it.

@akaszynski
Copy link
Member Author

akaszynski commented May 17, 2021

Full traceback on pyvistaqt==0.4.0

Traceback (most recent call last):
  File "/home/alex/tmp/tmp10.py", line 2, in <module>
    from pyvistaqt import BackgroundPlotter
  File "/home/alex/.local/lib/python3.8/site-packages/pyvistaqt/__init__.py", line 3, in <module>
    from pyvistaqt.plotting import BackgroundPlotter, MainWindow, MultiPlotter, QtInteractor
  File "/home/alex/.local/lib/python3.8/site-packages/pyvistaqt/plotting.py", line 55, in <module>
    from pyvista.plotting.theme import rcParams
ModuleNotFoundError: No module named 'pyvista.plotting.theme'

@adeak
Copy link
Member

adeak commented May 17, 2021

Ah, I see, this was fixed in pyvista/pyvistaqt#108 which is why the search didn't turn up anything. Thanks.

@akaszynski akaszynski deleted the fix/backwards_compat_rcParams branch June 24, 2021 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants