Add local fixtures in test_polydata #1326
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_polydata.py
module had a handful of global meshes that were being copied all over the place. This PR replaces them with module-level fixtures.One non-trivial change is that the now-local
sphere
fixture (coming frompv.Sphere
) shadows the globalsphere
fixture (coming frompv.examples.load_sphere
, ultimately reading a file with data arrays). This doesn't seem like an issue and the tests run fine.