-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some links and typos in examples #2030
Fix some links and typos in examples #2030
Conversation
"Build and push Docker image" step fails with
I wonder if this is due to the non-pyvista branch, or due to my user's lack of privileges. In comparison the also-recent #2029 didn't fail with this. This is something that needs to be looked at, because regular contributors will also trip it unless it's just some fluke (cc. @akaszynski). |
Codecov Report
@@ Coverage Diff @@
## main #2030 +/- ##
=======================================
Coverage 93.06% 93.06%
=======================================
Files 74 74
Lines 15531 15531
=======================================
Hits 14454 14454
Misses 1077 1077 |
I think it's auth issues. We may disable this for now. Pinging @banesullivan |
@banesullivan, I'm only building on tags. Is this fine? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We'll push only on tag for now to not block external contributors.
I'll look into the Docker build auth issues. I think I know what's going on there |
I came across some minor mistakes while browsing some examples.
Some notes:
marching_cubes
for the latter part of the example. Since flying edges works too, I changed to code accordingly.docs.pyvista.org
version). I wonder if this is somehow related to antialiasing. In any case my local build works fine for these figures.